From 55cdfae437bd1b82c933f0c4c9eabce97713cf2f Mon Sep 17 00:00:00 2001 From: Jarrod Johnson Date: Wed, 28 Aug 2024 19:18:43 -0400 Subject: [PATCH] Fix different invocations of check_fish Particularly nodediscover register can fail. Those invocations are XCC specific, so the targtype should not matter in those cases. --- confluent_server/confluent/discovery/protocols/ssdp.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/confluent_server/confluent/discovery/protocols/ssdp.py b/confluent_server/confluent/discovery/protocols/ssdp.py index 144c1b7a..0305a3ba 100644 --- a/confluent_server/confluent/discovery/protocols/ssdp.py +++ b/confluent_server/confluent/discovery/protocols/ssdp.py @@ -481,7 +481,11 @@ async def _find_service(service, target): async def check_fish(urldata, port=443, verifycallback=None): if not verifycallback: verifycallback = lambda x: True - url, data, targtype = urldata + try: + url, data, targtype = urldata + except ValueError: + url, data = urldata + targtype = 'service:redfish-bmc' try: wc = webclient.WebConnection(_get_svrip(data), port, verifycallback=verifycallback) peerinfo = await wc.grab_json_response(url, headers={'Accept': 'application/json'})