From 1085e342fdc4def6041739866a06aec0b7961381 Mon Sep 17 00:00:00 2001 From: Jarrod Johnson Date: Mon, 8 Aug 2016 09:11:59 -0400 Subject: [PATCH] Make missing NTP server return 404 Before it was returning 500 because of index out of range if a client was pulling an index unconditionally. --- .../confluent/plugins/hardwaremanagement/ipmi.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/confluent_server/confluent/plugins/hardwaremanagement/ipmi.py b/confluent_server/confluent/plugins/hardwaremanagement/ipmi.py index 2d89e181..53d2a23b 100644 --- a/confluent_server/confluent/plugins/hardwaremanagement/ipmi.py +++ b/confluent_server/confluent/plugins/hardwaremanagement/ipmi.py @@ -852,7 +852,12 @@ class IpmiHandler(object): else: idx = int(self.element[-1]) - 1 servers = self.ipmicmd.get_ntp_servers() - self.output.put(msg.NTPServer(self.node, servers[idx])) + if len(servers) > idx: + self.output.put(msg.NTPServer(self.node, servers[idx])) + else: + self.output.put( + msg.ConfluentTargetNotFound( + self.node, 'Requested NTP configuration not found')) return elif self.op in ('update', 'create'): if self.element[-1] == 'all':