Replace "assert type(...) is Foo" with "self.assertIsInstance(..., Foo)"
this produces a more meaningful test error message and fixes pep8 rule
E721[0]
[0] https://www.flake8rules.com/rules/E721.html
Fix below pep8 error message
zaza/openstack/charm_tests/ceilometer/tests.py:129:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinst
ance()`
One of the pep8 target dependencies must have updated,
causing a bunch of new lint errors in these categories:
- line length > 79 chars
- no whitespace after keyword
Since commit c98aa001f9, there are some
missing changes.
This stops the API check on Ocata when gnocchi is in play. Gnocchi must
be in play for Ocata but heretofore has not been.
The ceilometer setup script is a setup script not a test so it
should not raise a skip exception if it is not needed. The fact
that it does is my fault and was implemented on my recommendation.