Commit Graph

21 Commits

Author SHA1 Message Date
Liam Young
6246326729 Fix dashboard policy tests.
The dashboard policyd  override tests assume the deloyment is http
and non-ha. This is not a safe assumption so use the existing code
to generate the correct domain listing url.
2022-09-12 14:20:41 +00:00
Erhan Sunar
ba6cb0d1b7 Added tests for charm-openstack-dashboard
Added tests for checking positive and negative matches for the
Cache-Control and Pragma http headers.

If the requested resource is static check if these headers are
not set
Cache-Control: no-store
Pragma: no-cache

If the resource is dynamic ensure these headers are set
Cache-Control: no-store
Pragma: no-cache
2022-09-01 00:18:36 +03:00
Alex Kavanagh
0af4c93d52 Switch unit.public_address to unit.get_public_address()
Due to the bug [1] on OpenStack providers, unit.public_address doesn't
actually work reliably.  The fix [2] is only for the async function
unit.get_public_address().  Sadly, zaza relied on unit.public_address
and so it needs this patch for juju 2.9 support on OpenStack providers.

This patch relies on an associated patch in zaza [3]; thus this will
fails its tests until that passes.

[1]: https://github.com/juju/python-libjuju/issues/551
[2]: https://github.com/juju/python-libjuju/pull/600
[3]: https://github.com/openstack-charmers/zaza/pull/468
2022-01-14 15:21:32 +00:00
Chris MacNaughton
aa3807dfcc Add a request timeout, and pass in cacert when talking to horizon (#649) 2021-10-05 16:10:46 +01:00
Chris MacNaughton
d6dcf4fbd4 Remove duplicated code in Dashboard setup (#644) 2021-10-03 15:54:05 +01:00
Garrett Thompson
ce4fe12021 Revert "Skip security_checklist test for xenial_mitaka"
This reverts commit 1210e0c47e.

Rather than using an if statement for gating xenial_mitaka
and earlier, test cases can be customized in tests/tests.yaml
for individual bundles. This will be handled in review 774305.

[0] https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/774305
2021-02-11 12:43:04 -08:00
Garrett Thompson
1210e0c47e Skip security_checklist test for xenial_mitaka
See bug 1915293 [0] for more details, but this test is already skipped
in the repo's current state, this is just making it more explicit as
part of the current refactor.

[0] https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1915293
2021-02-10 18:42:32 -08:00
Garrett Thompson
5b9db73fc7 Fix indentation for pep8 2021-02-10 06:40:19 -08:00
Garrett Thompson
83e5dc798c Refactor security checklist test to another class
This will allow security checks to be logically separate from other
functional tests, and adhere to a similar design pattern that is
used in other charm tests (see nova [0]) for an example. It will also
highight which security checks are currently passing, and which are not.

[0] 35840a66d6/zaza/openstack/charm_tests/nova/tests.py (L485-L529)

Partial-Bug: #1883196
2021-02-09 19:47:40 -08:00
Liam Young
44adc1fb94 Fix policyd call to _login
8681b023 changed the signature of _login but did not update the
policyd test. This was not immediately picked up because the
policyd test is skipped before groovy due to Bug #1880959

Closes-Bug: #1911923
2021-01-19 10:42:20 +00:00
Liam Young
110dc534dd Add vip support 2020-08-19 15:47:44 +00:00
Liam Young
8681b02353 Support https in horizon tests
Update horizin tests to support https if available.
2020-08-19 12:36:23 +00:00
Frode Nordahl
f35da80f27 Unpin flake8, fix lint
Add Python 3.8 env in Travis CI test matrix.

At present the pinning of flake8 disallows running of lint on
Python 3.8 systems.

Update flake8 ignore-list to ignore W504 instead of W503, the PEP
guidance is that either is ok, but there must be local consistency.

There are more occurences of binary operator before line-break
than after in this repository, and we have also chosen to ignore
W504 in most of our other repositories.
2020-04-07 11:14:49 +02:00
Chris Johnston
50f59911dd Add docstring 2019-12-18 00:37:07 +00:00
Chris Johnston
7a2c0fb651 Additional tweak 2019-12-17 22:19:01 +00:00
Chris Johnston
9fc0602c64 Updates per review 2019-12-17 21:19:12 +00:00
Chris Johnston
2f88a94f97 Add Zaza tests for HAProxy expose functionality.
Partial-Bug: #1710208
2019-12-17 16:56:24 +00:00
Alex Kavanagh
4ac88e92bb Fix nit re: copy/paste comment 2019-11-21 13:04:14 +00:00
Alex Kavanagh
28db85e06c Fix more policyd tests so that they can work o-s dashboard
The difference in how openstack-dashboard and every other service uses
policies continues to create special cases.  This set of fixes deals
with some more of those differences.
2019-11-20 17:23:26 +00:00
Alex Kavanagh
c0db2def3b Modified policyd tests to support openstack-dashboard
* Addition of the (incomplete) openstack-dashboard test.
* Modification of other charm policyd override tests to support
  multi-file policy overrides resource ZIP.
2019-11-20 17:23:26 +00:00
Alex Kavanagh
47dc2a8b5f Add openstack-dashboard functional tests
This PR adds the ported from the amulet tests in the openstack-dashboard
charm.  This is launchpad bug: 1828424 [1]

[1]: https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1828424
2019-10-23 15:48:00 +01:00