Commit Graph

972 Commits

Author SHA1 Message Date
Liam Young 77cb2d0bd8 Fix doc string and lint 2021-03-24 13:52:34 +00:00
Liam Young 085d5a1513 Add RabbitMQDeferredRestartTest + fixes 2021-03-23 15:57:21 +00:00
Liam Young 1f47ef0bd7 Update package restart message afer ch change 2021-03-22 18:43:13 +00:00
Liam Young d4b8fbaed0 Rerun self.trigger_deferred_restart_via_charm 2021-02-25 11:01:22 +00:00
Liam Young 2054b7c477 Add test for deferred restarts 2021-02-25 09:16:34 +00:00
Garrett Thompson ce4fe12021 Revert "Skip security_checklist test for xenial_mitaka"
This reverts commit 1210e0c47e.

Rather than using an if statement for gating xenial_mitaka
and earlier, test cases can be customized in tests/tests.yaml
for individual bundles. This will be handled in review 774305.

[0] https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/774305
2021-02-11 12:43:04 -08:00
Garrett Thompson 1210e0c47e Skip security_checklist test for xenial_mitaka
See bug 1915293 [0] for more details, but this test is already skipped
in the repo's current state, this is just making it more explicit as
part of the current refactor.

[0] https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1915293
2021-02-10 18:42:32 -08:00
Garrett Thompson 5b9db73fc7 Fix indentation for pep8 2021-02-10 06:40:19 -08:00
Garrett Thompson 83e5dc798c Refactor security checklist test to another class
This will allow security checks to be logically separate from other
functional tests, and adhere to a similar design pattern that is
used in other charm tests (see nova [0]) for an example. It will also
highight which security checks are currently passing, and which are not.

[0] https://github.com/openstack-charmers/zaza-openstack-tests/blob/35840a66d6788dc4899847747ee7523895f46e1b/zaza/openstack/charm_tests/nova/tests.py#L485-L529

Partial-Bug: #1883196
2021-02-09 19:47:40 -08:00
Frode Nordahl 4cbf70dd5e octavia: Configure SSH key to allow debugging of Amphorae (#495) 2021-02-04 08:56:22 +01:00
Frode Nordahl 2ab9cebbf6 Use per-model tmp-dir to store local copy of CA cert (#493)
The current approach of storing the deployment CA certificate in
the 'test/' relative path does not allow for executing tests for
multiple targets from the same environment.

We have previously moved (7a90110) the local copy of the SSH
private key for similar reasons.

Remove the global constants as we cannot build them without making
function calls, and we'd rather avoid doing that at module import
time. Code using the location of the local CA certificate has
already been changed to use helper functions.
2021-02-04 08:48:17 +01:00
Garrett Thompson 7878523e34 Rename zaza_juju to be consistent with all of repo 2021-02-03 18:01:28 +00:00
Garrett Thompson 33ab875eb2 Replace get_relation_from_unit for ceph test 2021-02-02 09:58:13 -08:00
Garrett Thompson ea03e36273 Replace get_relation_from_unit for designate test 2021-02-01 15:50:31 -08:00
Aurelien Lourot 1b15ce22a5 Merge pull request #481 from gnuoy/bug/1706699
Run update-status before manila api test
2021-02-01 14:55:19 +01:00
Aurelien Lourot 5b8c1eccae Merge pull request #491 from gnuoy/bug/1896603
Skip OVN provider octavia test on Victoria
2021-01-30 16:22:45 +01:00
Liam Young c4691ef1c7 Skip OVN provider octavia test on Victoria
The OVN provider octavia test on Victoria is currently broken due
to Bug #1896603. Until it is fixed skip the test.
2021-01-29 13:51:25 +00:00
Frode Nordahl dc886f65d5 Add workaround for OVS-OVN migration on Groovy
The root of the issue is in Open vSwitch itself and it is not
easilly workaroundable in the charms.

We'll pursue a upstream/package level fix.
2021-01-28 10:25:52 +01:00
Aurelien Lourot d967231ad3 Merge branch 'master' into bug/1706699 2021-01-26 09:45:27 +01:00
David Ames 91924c5caf Merge pull request #488 from gnuoy/issues/487
Handle change of CA cert.
2021-01-25 11:45:34 -08:00
Liam Young 5be8fc3771 Fix docstring and bug 2021-01-25 11:41:39 +00:00
Liam Young e047150f5b Add unit tests 2021-01-25 09:21:00 +00:00
Liam Young 401829f0a7 Code tidy and docstrings 2021-01-24 17:24:20 +00:00
Liam Young d637646a9e Fix typo 2021-01-24 16:19:45 +00:00
Liam Young 24fbc068c9 Correct args to block_until_ca_exists 2021-01-24 15:27:06 +00:00
Liam Young a20733cd14 Refactor ca functions 2021-01-24 14:31:29 +00:00
Liam Young a828774c48 Handle change of CA cert.
Closes issue #487
2021-01-23 16:17:54 +00:00
Liam Young 44adc1fb94 Fix policyd call to _login
8681b023 changed the signature of _login but did not update the
policyd test. This was not immediately picked up because the
policyd test is skipped before groovy due to Bug #1880959

Closes-Bug: #1911923
2021-01-19 10:42:20 +00:00
Frode Nordahl 35840a66d6 nova: Conditional security checklist based on presence of vault
The current test expects Nova to never have TLS connections, let's
expect them to be there whenever vault is present.

Remove the 'is-volume-encryption-enabled' assertion as it is not
a property of the Nova security checks. This was previously masked
by the fact that action would always fail due to TLS tests not
being enabled for any bundles.
2021-01-16 22:36:44 +01:00
Alex Kavanagh d3f2a7d402 Merge pull request #483 from fnordahl/add-maas-helpers
Support configuring networknig charms on MAAS
2021-01-14 10:20:17 +00:00
Aurelien Lourot 2b715da7e4 Make HaclusterScalebackTest more robust (#482)
Note that this test will be superseded by #369 in the future.
2021-01-14 10:15:34 +01:00
Frode Nordahl ec63732974 Support configuring networknig charms on MAAS
When on MAAS support doing charm based configuration of OVS by
retrieving MAC address of ports attached to external network
from MAAS.

Note that we should extend the MAAS support to also work with
deployments where MAAS does the OVS configuration for us.
2021-01-13 18:47:08 +01:00
Frode Nordahl ee0dd80cec Split configure_gateway_ext_port function
The function does three separate things today, and two of its
tasks are useful for other provider types such as MAAS.

Also fix create_additional_port_for_machines idempotency.

We previously added a run time assertion to fail early when
attempting to configure networking for an invalid bundle. The
check had the side effect of prohibiting subsequent runs on
already configured models.
2021-01-13 18:47:05 +01:00
Aurelien Lourot a12a4a20e3 Merge pull request #446 from openstack-charmers/bug/1896729
octavia: Disable check for member operational status
2021-01-13 15:16:01 +01:00
Liam Young cdba5b64ca Run update-status before manila api test
The manila charm contains a 'band-aid' for Bug #1706699 which relies
on update-status to bring up services if needed. When the tests run
an update-status hook might not have run so services may still be
stopped so force a hook execution.
2021-01-12 13:13:36 +00:00
Aurelien Lourot bf4f412135 Merge pull request #456 from gnuoy/support-multiple-iscsi-gws
Stop assuming there are two iscsi gateways
2021-01-08 09:44:47 +01:00
Chris MacNaughton ebc51b490e Make the get_os_release default match get_current_os_release_pair 2021-01-06 17:19:56 +01:00
Alex Kavanagh 282b8be577 Update openstack upgrade tests for focal (#476)
This patch modifies the existing openstack upgrade tests so that they
work with focal (by explicitly supporting mysql-innodb-cluster), and are
also interruptable and resumable (at a charm level).  It also makes them
work with the udpated 'get_upgrade_groups()' that ultimately gets a List
of Tuples rather than a dictionary.
2021-01-06 14:09:41 +01:00
Aurelien Lourot b309199405 Merge pull request #478 from gnuoy/use-cephmon-for-release-pair
Use ceph-mon to check ceph version not keystone
2021-01-06 13:27:23 +01:00
Liam Young ddd9c74028 Use keystone in the first instance 2021-01-06 12:12:42 +00:00
Liam Young ed3b2737d1 Use ceph-mon to check ceph version not keystone
The test class BlueStoreCompressionCharmOperation gates tests on
whether the ceph release is mimic or newer but it uses the
keystone application to calculate the currently deployed version.
This PR switches the test class to ceck the version of ceph-mon
instead which makes more sense and the keystone application may
not always present in a ceph deployment.
2021-01-06 11:38:41 +00:00
Liam Young a35ba0917e Allow an app to be set when calling get_os_release (#477)
Ceph deployments may not contain a keystone service which causes
calls to get_os_release to fail as it calls get_current_os_release_pair
without sepecifying an application (keystone is the default).
2021-01-06 12:26:01 +01:00
David Ames cc26746762 Merge pull request #472 from mullumaus/bug/1907409
Add NovaComputeActionTest test class for virsh_audit action
2020-12-16 14:31:03 -08:00
Martin Kalcok 96592c6a85 Rename parameter disks to osds 2020-12-11 16:16:15 +01:00
Martin Kalcok cfdabe273a Adjust tests after rework of the 'service' action into start and stop actions 2020-12-11 09:49:33 +01:00
Linda Guo 10756f7a66 Add NovaComputeActionTest test class for virsh_audit action 2020-12-11 10:13:41 +11:00
Alex Kavanagh 7ced54b382 Concurrent series upgrade updates (#466)
* Updates to concurrent series upgrade

Updates to make it run more in parallel and spend less time waiting on
the whole model when updating machines.

* Make the concurrent series upgrade tests work

This is a number of changes to get the concurrent (here called
'parallel' historically) series upgrade tests to work.  A number of
changes were required which included limiting the number of concurrent
async co-routines (futures) that could be run as with large models it
hits the limits of the Py3 runtime.

* Fix the tests and change pause order in maybe_pause_things

Due to an additional model helper call, an additional model AsyncMock is
required.  Also the pause order had changed, and this is restored to
ensure the original design is retained (for pause order).

Clean up some commented out code and sort out a few PEP8 errors.

* Update comment to reflect code (3 -> 4)

* Fix tests that fail on bionic but pass on focal

Essentially, asyncio.gather has different behaviour on bionic that
focal.  Although this doesn't affect testing, it does affect the unit
tests.  These changes are simply to normalise the behaviour of unit
tests on focal and bionic.
2020-12-02 11:22:00 +01:00
coreycb 7f45d461e7 Log stderr when manila-ganesha verify() fails (#461) 2020-11-30 16:42:35 +01:00
Aurelien Lourot 83721ee8dd Merge pull request #438 from arif-ali/ldap-groups-membership-tests
Add ldap group/membership tests
2020-11-27 11:45:34 +01:00
Aurelien Lourot a8ca4720a3 Fix BlueStoreCompressionCharmOperation on Victoria (#468)
Before this fix, the test tried to determine the OpenStack
release based on the ceph-mon charm. Unfortunately Ceph has
the same version on Ussuri and Victoria. As a consequence
the test would wrongly conclude that it's testing against
"groovy_ussuri", which isn't a valid Ubuntu/OpenStack pair.

With this fix, the test now determines the OpenStack
release based on the keystone charm, with which we are able
to tell Ussuri and Victoria apart. This test class is being
run against the following charm functional tests at the
moment, which all have a keystone charm in their test
bundles: nova-compute, cinder-ceph, glance, ceph-fs,
ceph-radosgw and gnocchi.
2020-11-27 09:53:12 +01:00