From e5d2acc88c399fb549ac5d3971c8bff98775c534 Mon Sep 17 00:00:00 2001 From: David Ames Date: Fri, 26 Mar 2021 16:58:08 +0000 Subject: [PATCH] Fix test_vault_reload race condition The test_vault_reload test was checking for running config without giving the config-change time to complete. Simply adding an idle wait resolves the issue. Closes Issue: #528 --- zaza/openstack/charm_tests/vault/tests.py | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/zaza/openstack/charm_tests/vault/tests.py b/zaza/openstack/charm_tests/vault/tests.py index c5211e0..29719d5 100644 --- a/zaza/openstack/charm_tests/vault/tests.py +++ b/zaza/openstack/charm_tests/vault/tests.py @@ -273,23 +273,33 @@ class VaultTest(BaseVaultTest): running_config = vault_utils.get_running_config(lead_client) value_to_set = not running_config['data']['disable_mlock'] + logging.info("Setting disable-mlock to {}".format(str(value_to_set))) zaza.model.set_application_config( 'vault', {'disable-mlock': str(value_to_set)}) - logging.info("Testing reload") + logging.info("Waiting for modle to be idle ...") + zaza.model.block_until_all_units_idle(model_name=self.model_name) + + logging.info("Testing action reload on {}".format(lead_client)) zaza.model.run_action( juju_utils.get_unit_name_from_ip_address( lead_client.addr, 'vault'), 'reload', model_name=self.model_name) + logging.info("Getting new value ...") new_value = vault_utils.get_running_config(lead_client)[ 'data']['disable_mlock'] - logging.info(new_value) + + logging.info( + "Asserting new value {} is equal to set value {}" + .format(new_value, value_to_set)) self.assertEqual( value_to_set, new_value) + + logging.info("Asserting not sealed") self.assertFalse(lead_client.hvac_client.seal_status['sealed']) def test_vault_restart(self):