From ce4fe120219a3d23e9a4d917d37df33bee7f6433 Mon Sep 17 00:00:00 2001 From: Garrett Thompson Date: Thu, 11 Feb 2021 12:43:04 -0800 Subject: [PATCH] Revert "Skip security_checklist test for xenial_mitaka" This reverts commit 1210e0c47e9dc18edca047a2c784ad9409c35589. Rather than using an if statement for gating xenial_mitaka and earlier, test cases can be customized in tests/tests.yaml for individual bundles. This will be handled in review 774305. [0] https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/774305 --- zaza/openstack/charm_tests/openstack_dashboard/tests.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/zaza/openstack/charm_tests/openstack_dashboard/tests.py b/zaza/openstack/charm_tests/openstack_dashboard/tests.py index 36e7175..5cd341c 100644 --- a/zaza/openstack/charm_tests/openstack_dashboard/tests.py +++ b/zaza/openstack/charm_tests/openstack_dashboard/tests.py @@ -535,15 +535,10 @@ class SecurityTests(test_utils.OpenStackBaseTest, ] expected_passes = [ 'disable_password_autocomplete', + 'enforce-password-check', 'validate-file-ownership', 'validate-file-permissions' ] - if (openstack_utils.get_os_release() <= - openstack_utils.get_os_release('xenial_mitaka')): - logging.info("Test expected to fail until bug #1915293 is fixed") - expected_failures.append('enforce-password-check') - else: - expected_passes.append('enforce-password-check') logging.info('Running `security-checklist` action' ' on {} leader'.format(self.application_name))