From c76b7d423a4f3efff6e26e06db0dec179880ac3d Mon Sep 17 00:00:00 2001 From: Adam Dyess Date: Wed, 22 Jan 2020 13:20:42 -0600 Subject: [PATCH] improved docstrings for ldap tests --- zaza/openstack/charm_tests/keystone/tests.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/zaza/openstack/charm_tests/keystone/tests.py b/zaza/openstack/charm_tests/keystone/tests.py index 7f6e845..3b13f8c 100644 --- a/zaza/openstack/charm_tests/keystone/tests.py +++ b/zaza/openstack/charm_tests/keystone/tests.py @@ -395,7 +395,12 @@ class LdapTests(BaseKeystoneTest): return False, {} def _find_keystone_v3_user(self, username, domain): - """Find a user within a specified keystone v3 domain.""" + """Find a user within a specified keystone v3 domain. + @param str username: Username to search for in keystone + @param str domain: username selected from which domain + @return: return username if found + @rtype: Optional[str] + """ client = self.admin_keystone_client domain_users = client.users.list( domain=client.domains.find(name=domain).id @@ -417,7 +422,7 @@ class LdapTests(BaseKeystoneTest): can_config, config = self._get_ldap_config() if not can_config: raise unittest.SkipTest( - "Skipping API tests as no LDAP test fixture" + "Skipping API tests because there's no ldap-server" ) with self.config_change(