From 31d806c73148188ecaf7ff3f4a4b6f8705a13d8b Mon Sep 17 00:00:00 2001
From: Ray Chan <72372217+chanchiwai-ray@users.noreply.github.com>
Date: Tue, 5 Jul 2022 17:46:31 +0800
Subject: [PATCH] Add nrpe check tests for manila-ganesha charm (#806)

This PR adds nrpe check tests for manila-ganesha charm. It's accompanied by the new features proposed in https://review.opendev.org/c/openstack/charm-manila-ganesha/+/848219

- Added tests for nrpe check in manila-ganesha.
- Check if the custom plugins are being installed
- Check if the custom cronjobs are being installed
- Check if the NRPE services are being added.
- The tests will not be ran if nrpe does not exists.
---
 .../charm_tests/manila_ganesha/tests.py       | 65 +++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/zaza/openstack/charm_tests/manila_ganesha/tests.py b/zaza/openstack/charm_tests/manila_ganesha/tests.py
index 0e99871..7db9569 100644
--- a/zaza/openstack/charm_tests/manila_ganesha/tests.py
+++ b/zaza/openstack/charm_tests/manila_ganesha/tests.py
@@ -17,11 +17,13 @@
 """Encapsulate Manila Ganesha testing."""
 
 import logging
+import tenacity
 
 from zaza.openstack.charm_tests.manila_ganesha.setup import (
     MANILA_GANESHA_TYPE_NAME,
 )
 
+import zaza.openstack.utilities.generic as generic_utils
 import zaza.openstack.charm_tests.manila.tests as manila_tests
 import zaza.model
 
@@ -56,3 +58,66 @@ class ManilaGaneshaTests(manila_tests.ManilaBaseTest):
                     unit.entity_id,
                     "systemctl stop manila-share nfs-ganesha")
         return True
+
+    def _run_nrpe_check_command(self, commands):
+        try:
+            zaza.model.get_application("nrpe")
+        except KeyError:
+            self.skipTest("Skipped NRPE checks since nrpe is not deployed.")
+
+        units = zaza.model.get_units("manila-ganesha-az1")
+
+        for attempt in tenacity.Retrying(
+            wait=tenacity.wait_fixed(20),
+            stop=tenacity.stop_after_attempt(2),
+            reraise=True,
+        ):
+            with attempt:
+                ret = generic_utils.check_commands_on_units(commands, units)
+                self.assertIsNone(ret, msg=ret)
+
+    def test_903_nrpe_custom_plugin_checks(self):
+        """Confirm that the NRPE custom plugin files are created."""
+        plugins = [
+            "check_nfs_conn",
+            "check_nfs_exports",
+            "check_nfs_services",
+        ]
+
+        commands = [
+            "ls /usr/local/lib/nagios/plugins/{}".format(plugin)
+            for plugin in plugins
+        ]
+
+        self._run_nrpe_check_command(commands)
+
+    def test_904_nrpe_custom_cronjob_checks(self):
+        """Confirm that the NRPE custom cron job files are created."""
+        cronjobs = [
+            "nfs_conn",
+            "nfs_exports",
+            "nfs_services",
+        ]
+
+        commands = [
+            "ls /etc/cron.d/nagios-check_{}".format(cronjob)
+            for cronjob in cronjobs
+        ]
+
+        self._run_nrpe_check_command(commands)
+
+    def test_905_nrpe_custom_service_checks(self):
+        """Confirm that the NRPE custom service files are created."""
+        services = [
+            "nfs_conn",
+            "nfs_exports",
+            "nfs_services",
+        ]
+
+        commands = [
+            "egrep -oh "
+            "/usr/local.* /etc/nagios/nrpe.d/check_{}.cfg".format(service)
+            for service in services
+        ]
+
+        self._run_nrpe_check_command(commands)