From 04159f738f92ee49c94440c9a7b67f203be1ed8c Mon Sep 17 00:00:00 2001 From: "Koushik K. Dutta" Date: Thu, 25 Mar 2010 19:04:08 -0700 Subject: [PATCH] epic fail on my part. integer overflow. the s_bfree and such are all long values --- Android.mk | 2 +- nandroid.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Android.mk b/Android.mk index b5def18..0b064ff 100644 --- a/Android.mk +++ b/Android.mk @@ -26,7 +26,7 @@ LOCAL_MODULE := recovery LOCAL_FORCE_STATIC_EXECUTABLE := true -RECOVERY_VERSION := ClockworkMod Recovery v1.7.8.0 +RECOVERY_VERSION := ClockworkMod Recovery v1.7.8.1 LOCAL_CFLAGS := -DRECOVERY_VERSION="$(RECOVERY_VERSION)" RECOVERY_API_VERSION := 2 LOCAL_CFLAGS += -DRECOVERY_API_VERSION=$(RECOVERY_API_VERSION) diff --git a/nandroid.c b/nandroid.c index 5a54f45..5b931aa 100644 --- a/nandroid.c +++ b/nandroid.c @@ -108,8 +108,8 @@ int nandroid_backup(char* backup_path) struct statfs s; if (0 != (ret = statfs("/sdcard", &s))) return print_and_error("Unable to stat /sdcard\n"); - int sdcard_free = s.f_bfree * s.f_bsize; - if (sdcard_free < 150000000) + long sdcard_free = s.f_bfree * s.f_bsize; + if (sdcard_free < 150000000L) return print_and_error("There is not enough free space on the SD Card! At least 150MB is required to create a backup.\n"); char tmp[PATH_MAX];